Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image tag that was being used by openshift ci #385

Conversation

Jooho
Copy link

@Jooho Jooho commented Jul 12, 2024

What this PR does / why we need it:
openshift ci will set different tag name so params.env need to use it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # https://issues.redhat.com/browse/RHOAIENG-9790

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

@openshift-ci openshift-ci bot requested review from israel-hdez and spolti July 12, 2024 09:20
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-operator does not have the pipeline for release-v0.12.1: https://github.com/openshift/release/tree/master/ci-operator/config/opendatahub-io/kserve

So, I'm quite confused... what is pushing that v0.12.1 tags in quay?

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I read some messages where you tell you created this manually.
OK ;-)

Copy link

openshift-ci bot commented Jul 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e99da7a into opendatahub-io:release-v0.12.1 Jul 13, 2024
18 checks passed
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request Aug 28, 2024
…lux/component-updates/kserve-router-210

Update kserve-router-210 to 0478db5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants